Results 782 comments of BenBE

Minor fixup during the week (missed to delete one LOC in the original patch). Patch should do as expected; looking for reviews and tests.

Looking forward. If you need anything feel free to ask. Not yet tested (lack of suitable test system on my side). Confident it should work though.

Further update: I included 5aa305a yesterday to fix some issues with compilation when using OpenSSL 1.1.1-dev from branch tls1.3-draft-19. While this compiles (and does not crash immediately) I still see...

And a second minor issue found with the ssl_ct_log directive I introduced: Forgot both to add it for mail servers AND to actually initialize it to unset ... Patch in...

The branch received some more refinements (somehow the ssl_ct_log directive got messed up and wasn't handled properly, among some other issues). Current set of changes can be found at https://github.com/grahamedgecombe/nginx-ct/compare/master...BenBE:check_sct?expand=1...

Latest version on my branch seems to work (it properly detects all the SCT to attach), but for some reason fails to include them in the ServerHello (debugging this part)....

Are you sure you have all the necessary developement files installed on Snow Leopard in order to successfully use apxs for module compilation?

Please recheck with current master. I just merged in some changes that might have resolved your problem. Please also note the other issues (#6, #19) standing with mod_passenger.

Further digging showed that the $(CFLAGS) provvided in the Makefile aren't accepted by apxs2 when called from dh_auto_install. Unfortutnally trying to provide proper CFLAGS through -Wc, and -Wl,LIBDIR caused the...