Results 767 comments of BenBE

@Explorer09 Please check this updated patchset. I think there broke something on rebase.

@Explorer09 I pulled in your patches (took me a bit to compare with what I already had). LGTM. I noticed a small issue with the LED mode of the Battery...

> > I noticed a small issue with the LED mode of the Battery meter: When you switch from LED mode to Text mode, you see the LED mode text...

> @BenBE By the way. I feel little uncomfortable when we allow a `supportedModes` field to be zero. If possible, I would like all meters to have explicit `supportedModes`. This...

> > > > I noticed a small issue with the LED mode of the Battery meter: When you switch from LED mode to Text mode, you see the LED...

@Explorer09 Anything else to do in your opinion? Otherwise I'd go ahead an merge this one soon …

> My questions: > > 1. Should this new graph style considered a new mode (like in `Bar`, `Text` and `LED` meter modes) or a "sub-style" under the `Graph` meter...

I think the values technically make sense: The idle process has the lowest priority (i.e. when nothing else can run) while the kernel processes below it have the highest priorities...

So effectively with this patch, instead of say "Intel i7-7590K" you now have "100" as the brand string? I think that might look a bit surprising and I think from...

The sorting in tree mode works based on the direct children for each parent. Unfortunately, in the 3.3.0 release there has been a bug (cf. #1378), which got resolved in...