Ben Brady

Results 7 comments of Ben Brady

I lost the original benchmark I used, I recreated it but it's not exact. I took some schemas from my own project, applied the jsonable_encoder to them 10,000 times and...

Any updates on this? The main thing from stopping me from using this library is the lack of documentation.

also here's the benchmark I used to test it, based on an application I made a while ago ``` from fastapi.encoders import jsonable_encoder from pydantic import BaseModel as _PydanticBaseModel, Field...

> Perhaps this was an optimization because enums are used more frequently than other entries in ENCODERS_BY_TYPE I tried benchmarking it and it only makes a very slight difference ###...

> @Ben-Brady, thank you for working on this! > > Could you please take a look at my comments? > > Also, I think we should refactor this PR to...

Yeah a JSON file isn't ideal. A simpler solution would just be to encode file data instead, as it would be much simpler to implement. Base64/Base96 encoding the files would...

Ah, if this can be done with adding a script to the autorun then I don't think it needs to be implemented in the core mod. If someone wants this...