Groot icon indicating copy to clipboard operation
Groot copied to clipboard

Support subtree include

Open doisyg opened this issue 5 years ago • 5 comments

Groot currently doesn't support trees referencing subtree through the include tag, even the simplest form when the second xml is in the same folder or specified with the full absolute path. A tab is open for the subtree referenced but it is empty.

doisyg avatar Aug 19 '19 13:08 doisyg

@facontidavide, any progress or thoughts?

ramilmsh avatar Oct 04 '19 09:10 ramilmsh

bumping this, would be nice to see progress here. Is there any? :)

I honestly cannot fathom why Groot has its own implementation of XML-parsing rather than letting BehaviorTree.CPP do that part and just use the resulting tree(s). This is doomed to always run into problems sooner or later.

kb0n avatar Feb 26 '21 15:02 kb0n

dear @kb0n , I don't have bandidth to support Groot anymore.

be my quest and submit a pull request

facontidavide avatar Feb 26 '21 15:02 facontidavide

The usual problem we all face unfortunately :)

I'll have the evaluate the urgency for us and see if can make up some capacities for tackling this. Was there a particular reason for Groot to use its own parser? Just so I can avoid running into the same problems you already faced. Thanks!

kb0n avatar Feb 26 '21 16:02 kb0n

The main reason is that the original parser is use to create an instance of a Tree.

Groot is NOT supposed to create an instance of the tree, therefore I don't see how code reuse is even possible (spoiler alert: is not).

facontidavide avatar Feb 26 '21 16:02 facontidavide