Bas Broek comments

Results 80 comments of


                                            Bas Broek

Sign in after sign out issue

Oh yeah this is tricky. 😕 I guess we go back to `SFSafariViewController`? Is there really no way to sign out with `SFAuthenticationSession`? Seems weird.

Allow for quick toggle between open/closed issues

Oh and one more question... what if I want to search for _both_ closed and open issues? That doesn't seem to be possible anymore.

VoiceOver should select all of comment header except "..."

I could use some help with this. I am unsure how we should / can group the image, username and label (but leaving out the `...`). Should we add them...

VoiceOver should select all of comment header except "..."

If we go that route, we would probably end up with something like this (simplified): ```swift let containerView = UIView() // contains the image, username label and date label containerView.isAccessibilityElement...

VoiceOver should select all of comment header except "..."

Nice! Will take a look tomorrow. Good one regarding edits! Sent with GitHawk

Keyboard Shortcuts

yessss

Keyboard Shortcuts

And we should check for which ones it would make sense to make them discoverable. Maybe we won't need to add all of them there.

Keyboard Shortcuts

Also up/down arrows to browse lists :)

Keyboard Shortcuts

Will try to start tackling this soon!

Keyboard Shortcuts

Thanks for the warm welcome! 😍