GitHawk icon indicating copy to clipboard operation
GitHawk copied to clipboard

Allow for quick toggle between open/closed issues

Open Huddie opened this issue 6 years ago • 8 comments

Currently, a WIP, looking for some feedback. Closes #374

Quick description:

During Editing: Segment Bar recedes allowing easy typing

When Finished Editing: Segment Bar appears allowing a quick move between closed/open issues

It currently does update the state properly and the list does refresh properly

Huddie avatar Mar 13 '19 01:03 Huddie

Simulator Screen Shot - iPhone XR - 2019-03-12 at 21 11 11 Simulator Screen Shot - iPad Pro (11-inch) - 2019-03-12 at 21 10 07 Simulator Screen Shot - iPad Pro (11-inch) - 2019-03-12 at 21 10 02

Huddie avatar Mar 13 '19 01:03 Huddie

That’s inspired work!

Sent with GitHawk

wayni208 avatar Mar 13 '19 10:03 wayni208

Awesome @huddie

3 f/u

  • Does hitting open again, deselect it allowing for both open and closed to show
  • if one manually types is:open or is:closed does it automatically convert to the use of the filter?
  • Would you agree that this would be excellent to have on home screen inbox as well. I’d strongly vote yes, though I do understand it’d be slightly tougher to design in.

ijm8710 avatar Mar 13 '19 13:03 ijm8710

This PR will not include anything on the inbox but if you’re interested in that open an issue maybe with a design?

If one manually types is:open/closed, it will pass that along in the query, this does not effect the original query string.

It’s a segment control so yes, it’s to toggle between open and closed. Maybe I’ll put together a custom multi-select. Won’t be getting around to this for a week at least.

Sent with GitHawk

Huddie avatar Mar 13 '19 14:03 Huddie

Oh and one more question... what if I want to search for both closed and open issues? That doesn't seem to be possible anymore.

BasThomas avatar Mar 14 '19 18:03 BasThomas

Oh and one more question... what if I want to search for both closed and open issues? That doesn't seem to be possible anymore.

Gonna switch out the segment control for a custom control that allows mutli selection. End result will look the same + allow multiple selection thereby open and closed or none

Huddie avatar Mar 14 '19 23:03 Huddie

@Huddie Have you had the time to look into adding it? Or someone else should take hold of this PR?

nikivdev avatar Nov 09 '19 23:11 nikivdev

I will try to finish this week. Otherwise I’ll let you know and it would be awesome if you or someone else picked it

Sent with GitHawk

Huddie avatar Nov 09 '19 23:11 Huddie