Barak Mordehai
Barak Mordehai
Hey @maiqueb , Thanks for refactoring this. Overall it looks like the right path. But what about using this logic in the migration controller? https://github.com/kubevirt/kubevirt/blob/30011371a174a71383d28ca85aea6f2be164ef0b/pkg/virt-controller/watch/migration.go#L1655 Do you think that it...
> > Hey @maiqueb , Thanks for refactoring this. Overall it looks like the right path. But what about using this logic in the migration controller? > > https://github.com/kubevirt/kubevirt/blob/30011371a174a71383d28ca85aea6f2be164ef0b/pkg/virt-controller/watch/migration.go#L1655 >...
Hey @jrcichra , Actually we stopped considering this field because it might cause problems when migrating with `host-model` CPU-Model. Please have a look in: https://github.com/kubevirt/kubevirt/pull/7765 But we do need to...
> Hey @Barakmor1. I understand the value these labels have for features like live migration. But in a homogenous cluster without live migration enabled, the number of kubevirt labels is...
Already Done. https://github.com/kubevirt/user-guide/pull/575
Hey these Counters doesn't sound like reliable source for time measurement , What about counter reset? Counters are allowed to be reset to 0.
Maybe we can create an event when a vm is stuck in a status and than create an alternative metric and fire an alert.( just a thought ) something like:...
To be honest i don't understand why should we deviate from the way we usually generate alerts. Take `LowVirtOperatorCount` for instance: ``` Alert: "LowVirtOperatorCount", Expr: intstr.FromString("(kubevirt_allocatable_nodes_count > 1) and (kubevirt_virt_operator_up_total...
/sig code-quality