Bano Rani

Results 10 comments of Bano Rani

Hi @joelbrostrom, I’ve added a PR that addresses this! 🎉 It includes a trophy rank table with points needed for each level and descriptions for better transparency. This should make...

Thanks for the feedback, @joelbrostrom! Yes, exactly — the table shows estimated points and levels for reference. Actual trophy ranks can vary depending on the specific calculation for each trophy,...

Thanks for your suggestion, @joelbrostrom! I totally understand — having exact thresholds for each trophy would make the experience more like a “game grind.” The challenge is that the actual...

Thanks for the clarification, @hesreallyhim! That makes sense — the “secret” seems to just mean “not documented,” and the calculations are visible in the source code. I’ll take a look...

Hi @joelbrostrom and everyone! 👋 I’ve gone through the source code and created a table showing **trophy ranks, points needed, and descriptions**. Please note this is for **reference only**, as...

Hi @BioGavin I think for workflows like antiSMASH parsing, a post-processing step to remove whitespace or concatenating multi-line values would be a practical workaround. If /domain_id appears frequently enough in...

Hi maintainers, The failing tests are expected because this PR removes `convert(::T, x)` for mutable BioSequence types. Some downstream packages and older Julia versions rely on `convert`, so these tests...

Thanks for the review, @kescobo! For the commented-out Base.convert lines in constructors.jl, I left them temporarily so we could double-check behavior during testing. I can go ahead and remove them...

Hi @kescobo Thanks for the feedback! I’ve pushed an update that: removes the commented-out convert methods completely removes the “Object identity” test, as suggested Let me know if you'd like...

Instead of using the implicit convert method for mutable types like BioSequence, we could remove it to avoid confusion with object identity. A recommended approach is to use explicit constructors...