Jussi Timperi
Jussi Timperi
Next failure: > Too few arguments for subroutine 'ProductOpener::Store::get_urlid' at tests/unit/store.t line 16. https://github.com/openfoodfacts/openfoodfacts-server/blob/76395069b4c75edfa465fae41517ba8d98af3e0e/tests/unit/store.t#L16 This can be solved similarly to `get_fileid`, make only one argument required and the rest optional.
So far, I've compiled this XML of the complete list: https://gist.github.com/Ban3/e497c22af7446158ce65a3e2d007a7ec
Origin check in ingredients parser could be used for 'animal'. There's already a check for plant origin, this would be just the opposite of that. https://github.com/openfoodfacts/openfoodfacts-server/blob/5241e9a12dfd5502d20300f1f2d2231fe337e755/lib/ProductOpener/Ingredients.pm#L1006-L1009
This is really common in Finnish, Scandinavian languages, German, Dutch and probably bunch of other languages, so I've been toying with some ideas for normalizing lists like that. I actually...
@svensven #3086 wikidata should offer a good solution for "British pork", but the current workaround is indeed adding it to the ingredients taxonomy. Ingredients.pm already handles origins in parentheses like...
The docs do show the image upload like your cURL, but is the documentation actually correct? The cURL equivalent what the official apps are doing is more like: ```sh curl...
> i changed product_image_upload.pl/imgupload_front to imgupload_front and there are still no changes, still success on the api call but no image on product page Did you notice the different endpoint...
> i'll keep digging, i'm doing something wrong with the image data, i don't think it's related to OFF anymore. Yeah, my guess is that receives 0 bytes, hence 'too...
in addition to comments by @hangy, SonarCloud has quite a few complaints about missing `var` in declarations. I assume most of these aren't meant as globals.
Works for me 