Jussi Timperi

@ReservedField Ah, sorry, I was a bit unclear. That was what I meant by not matching as there are fewer versions of Presa devices. SDK supports them all so it's...

You need python headers: `sudo apt-get install python-dev`

I took a look at [bin/cover](https://metacpan.org/release/PJCJ/Devel-Cover-1.38/source/bin/cover) in hopes to emulate what `cover -test` does. It boils down to two things: Delete the DB and set the environment to include `-MDevel::Cover`...

> I took a look at [bin/cover](https://metacpan.org/release/PJCJ/Devel-Cover-1.38/source/bin/cover) in hopes to emulate what `cover -test` does. It boils down to two things: Delete the DB and set the environment to include...

I looked at `RequireBriefOpen` when we were doing the severity 4 PR, and IIRC there were few subroutines that would need significant refactoring to pass the default close within 9...

These are the policies in the `Perl-Critic` distribution with the default severity of 4: - [BuiltinFunctions::RequireBlockGrep](https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep) Write `grep { /$pattern/ } @list` instead of `grep /$pattern/, @list`. - [BuiltinFunctions::RequireBlockMap](https://metacpan.org/pod/Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap) Write...

Looks like you uncovered a bug by converting a subroutine to using a signature. The tests are failing with: ``` Too many arguments for subroutine 'ProductOpener::Store::get_string_id_for_lang' at /opt/product-opener/lib/ProductOpener/MissionsConfig.pm line 234....

Another one with extra `1` at the end. Should be removed: https://github.com/openfoodfacts/openfoodfacts-server/blob/c922fc3e79d127fd58d7f62f9ef54d50e54b8f80/lib/ProductOpener/Tags.pm#L3737 This is calling a subroutine with too few arguments: https://github.com/openfoodfacts/openfoodfacts-server/blob/c922fc3e79d127fd58d7f62f9ef54d50e54b8f80/tests/unit/store.t#L11 Something like `get_fileid('Do not challenge me!', 0, 'en')`...

Actually, an additional way to handle too few arguments would be giving the parameters default values, if we don't want to touch the calls. ```perl sub get_fileid($file, $unaccent=undef, $lc=undef) ```...

> Would making it like this be the same? No, that would still require 3 arguments and overwrite `$unaccent` and `$lc` with undef even when they are provided. The only...