Olivier Mélois
Olivier Mélois
Awesome, thanks for the context. My day has been derailed a bit and unfortunately I've not had time to give it a try today, but I'll definitely do so over...
Hi there, sorry I haven't replied until now, things have been really chaotic at work (I work for Disney) and I admit I had forgotten to send you feedback because...
Alright I've tested and mostly it works fine, and I'm reasonably happy with the workflow it provides, but I can't merge the PR until `vsce package` and `vsce publish` are...
> The complete build output is assembled in the directory target/scala-2.13/scalajs-bundler/main. (I have added a new command for doing that.) When I run vsce package in that directory, an installable...
On a totally unrelated note : it's usually deemed a bad idea to amend commits / force-push after you've opened a pull-request and people started commenting on it. It makes...
Mmm I'm sorry to say I have no idea why it wouldn't work. The line of code that stores things in the clipboard is [there](https://github.com/Baccata/vscode-scaladex-search/blob/master/src/main/scala/extension.scala#L127), it's literally just using the...
Hi there, thanks for raising the issue 👍 . I'm planning on moving this extension to https://github.com/neandertech/, and unify the code with https://github.com/neandertech/dexsearch (which is a CLI that achieves the...
> Consider not reloading the model on didChange, doing it only in didSave instead. I think this should be pursued no matter what : recompiling on `didChange` is a pretty...
From what I gather, the current behaviour of `didChange` stores the buffered contents into a [map](https://github.com/smithy-lang/smithy-language-server/blob/c7931522c11c8b07a8a6eb13ecfad5370c18206e/src/main/java/software/amazon/smithy/lsp/SmithyTextDocumentService.java#L643), such that completion requests can retrieve the [token that's being edited](https://github.com/smithy-lang/smithy-language-server/blob/c7931522c11c8b07a8a6eb13ecfad5370c18206e/src/main/java/software/amazon/smithy/lsp/SmithyTextDocumentService.java#L229), before looking it...
> syntax errors are fair game I think, and mayybe loading the model with no external validators (maybe this part could be configurable?), but I'd say we should save validators...