BabuSrithar

Results 4 comments of BabuSrithar

*[`pkg/ccl/oidcccl/authentication_oidc.go` line 713 at r4](https://reviewable.io/reviews/cockroachdb/cockroach/119013#-NrB562h427UE-MaSZW-:-NrB562h427UE-MaSZW0:b878fc8) ([raw file](https://github.com/cockroachdb/cockroach/blob/ecd8633b29e5b8dd3e5f07df6f5f59f95c828be9/pkg/ccl/oidcccl/authentication_oidc.go#L713)):* > ```Go > > if !oidcAuthentication.enabled { > http.Error(w, "OIDC: disabled #2", http.StatusBadRequest) > ``` the #2 and #3 later in the file...

*[`pkg/ccl/oidcccl/authentication_oidc.go` line 725 at r4](https://reviewable.io/reviews/cockroachdb/cockroach/119013#-NrB5ZcW7zp_8BY_mgQx:-NrB4oKf0z30rbOvgaF0:b-h5zonk) ([raw file](https://github.com/cockroachdb/cockroach/blob/ecd8633b29e5b8dd3e5f07df6f5f59f95c828be9/pkg/ccl/oidcccl/authentication_oidc.go#L725)):* > ```Go > } > > if !oidcAuthentication.enabled { > ``` Just for my clarification, can the value of `oidcAuthentication.enabled` between line 712...

*[`pkg/ccl/oidcccl/authentication_oidc.go` line 725 at r4](https://reviewable.io/reviews/cockroachdb/cockroach/119013#-NrB5ZcW7zp_8BY_mgQx:-NrJWexDAWWpguml3hJQ:bbvmmgw) ([raw file](https://github.com/cockroachdb/cockroach/blob/ecd8633b29e5b8dd3e5f07df6f5f59f95c828be9/pkg/ccl/oidcccl/authentication_oidc.go#L725)):* Previously, dhartunian (David Hartunian) wrote… @BabuSrithar the two checks are not the same and you can reach the second one if the first...

Here is latest from drt-chaos cluster https://us5.datadoghq.com/logs?query=-status%3A%28info%20OR%20debug%29%20cluster%3Adrt-chaos&agg_m=count&agg_m_source=base&agg_t=count&cols=host%2Cservice&event=AgAAAZBnrQdZtckJMwAAAAAAAAAYAAAAAEFaQm5yUWRaQUFBZjM3dURqWFlfNlFCcQAAACQAAAAAMDE5MDY3YmEtOTUwMC00ZjI4LWI4YzctOGQxZTAzMjk3OTQ5&fromUser=true&messageDisplay=inline&refresh_mode=paused&storage=flex_tier&stream_sort=time%2Casc&viz=stream&from_ts=1719726300000&to_ts=1719727920000&live=false