Ben Reeves comments

Results 31 comments of


Ben Reeves

Requiring an `[x+1, y+1, z+1]`-sized buffer is inconvenient.

Ah, see, I don't particularly care (at the moment) about skipping occluded faces on chunk boundaries. I'm just generating full meshes for each individual chunk for the time being.

Requiring an `[x+1, y+1, z+1]`-sized buffer is inconvenient.

Probably :)

Bindgen becomes incredibly slow when using `--enable-function-attribute-detection` with newer-style `[[attribute]]` syntax.

@emilio Do you have any idea why it's only slower with the `[[...]]` syntax but not with the `__attribute__((...))` syntax?

Allow users to specify adding return value to field in instrument attribute

Dupe of #1281 I think

libpmemobj: Allocated objects not aligned to cache boundaries

Thank you for the clarification. I agree, the documentation should be improved to clarify these things, to avoid future programmers from making these same assumptions.

Allow specialized const trait impls.

@rustbot label +A-specialization +A-traits +F-specialization +F-const_trait_impls EDIT: whoops i thought you could do that for PRs

Allow specialized const trait impls.

At long last 🎉 I'll take a stab at it later today. I imagine it will be more involved than just a rebase, right? IIRC there was some sort of...

Allow specialized const trait impls.

@rustbot ready

Allow specialized const trait impls.

@rustbot ready

Allow specialized const trait impls.

@JohnCSimon the PR status is correct, I was requested to add an additional test and tweak the behavior of the code. I never got around to it. Let me see...