Sergio Aquilini

Results 68 comments of Sergio Aquilini

We are having the same issue with nullable reference types. Fixing it via attributes isn't trivial as the `Should().NotBeNull()` construct makes it impossible to properly set the needed attributes. My...

See draft PR -> https://github.com/fluentassertions/fluentassertions/pull/1689

Yes @dennisdoomen, it works but it’s a lie. Calling `Should` doesn’t guarantee that `actualValue` will not be `null` afterwards. You didn’t enable the NRT and/or the `actualValue` argument isn’t declared...

I see what you mean but it's wrong in my opinion. You are just suppressing the compiler null check without actually checking for null on your part. It's not very...

If would have thought that `NotBeOfType` wouldn't consider `null` a violation. Nice to know. The principle is still valid. The following code throws a `NullReferenceException` (this time around I actually...

Yes, I mean that your hack in the `Should` method disables the null reference check at compile time and I therefore disagree with it. I understand it might not be...

I see. I totally understand your point of view. In this case, I'd just leave it alone. 😉

The admin API is not covered (not abstracted, not proxied) by Silverback. Internally I use it to get the topic metadata and the `IConfluentAdminClientBuilder` was added explicitly for that and...

@CeeJayCee, what would you expect from Silverback to help you with a cleaner implementation?

> It would be nice if Silverback provided a configuration option to create the topic with options if it doesn't exist. Maybe in the `IEndpointsConfigurator`? I'm considering this for a...