Brian Quinn

Results 7 comments of Brian Quinn

I'd like this too, in my case I'd like to wrap a `deploy` of an ECS cluster so I can scale it manually after the deploy is done (I create...

So you only want 90c837f + 4da6f63 merged?

@maximkulkin I don't really understand your first comment regarding the use of DocumentFragment vs Document. If I use Document it will wrap the elements with: `, ` tags automatically -...

Ohh and there's an issue with certain selectors processed against DocumentFragement which work against Document?

@matfiz it might just be that Deface can't find the haml engine when loading (so it doesn't require the hamlconverter). Can you confirm that haml is required when running the...

Here's where we set the config: https://github.com/spree/deface/blob/master/lib/deface/railtie.rb#L22 I'm open to suggestions for a different hook to add it :before ?

This is a new one for me, I'll take a look and see if I can replicate.