Martin Adámek
Martin Adámek
any updates on this one @milesj?
We will most likely do that later this year, but the support for doing this "somehow" should be done during Q3, so let's try to make it work now on...
Yes, we need some tests, both works fine, but I am not sure now how to implement checks for the E2E tests really. > I'm not even running this code...
you will need to add some tests. maybe the e2e test could do the job here, we at least need to know it wont break anything, we can check how...
> We may not need the global accessors (e.g., Dataset.open) The `open` methods are actually the only ones we might need. > We should cleanly separate filesystem-backed and memory-only storage...
I see, so the default would be the file system one. Then I am not sure what benefits this would bring, pretty much all the problems we had were about...
> Should work with current memory-storage, does it not? memory-storage definitely supports it to my knowledge (.s.getOrCreate() -> new UUID) This would work out of box already if we remove...
Historically things were snake case, but I believe nobody from the current team is in favor of that (I never like this). I would go with kebab case for anything...
> I'd argue that since this really is just a refactor, new tests shouldn't be necessary This is a feature, not a refactor. We are adding a new public option...
> This is a feature, not a refactor. We are adding a new public option that enables new behavior. This also reminds me we need some docs around it. It...