Martin Adámek comments

Results 768 comments of


                                            Martin Adámek

Add support for Embedded column name

Ok, but that might be just a type-level issue, have you tried to put it in (and cast the options `as any`)?

fix(entity-generator): fix generation of entities with identifiers that overlap with core

FYI I am still not sold on the idea of introducing ts-morph here, I don't really plan to merge this unless you find a way to get rid of that...

Naming errors in Entity Generator

This is getting quite stale, are we missing some fix, a reproduction, or can we close?

Naming errors in Entity Generator

> Simply stripping out the schema name blindly isn't a good fix, because a FK may reference a different schema Yes, but the FK property should never contain the schema...

SQLite returns timestamp for date fields defined by `t.datetime` in a populated entity

> define property with @Property({ type: t.datetime }) or @Property({ type: DateTimeType }) (recommended in [docs](https://mikro-orm.io/docs/guide/first-entity#scalar-properties)) Where do you read it's "recommended"? I would actually discourage it, since it means...

SQLite returns timestamp for date fields defined by `t.datetime` in a populated entity

> Other ways ('datetime'|'Date'|Date) work fine Any of those. When you use the types map, you use the custom type, which in fact does nothing (but the hydration functions still...

perf: optimize adding large amount of requests via `crawler.addRequests()`

e2e tests running here https://github.com/apify/crawlee/actions/runs/9032841278

Improve docs about request locking

Is this for your team or do you want us to handle it?

Improve docs about request locking

@drobnikj let me ask again, is this for you or for us? :]

Trouble unzipping `sitemap.xml` (`zlib: incorrect header check`)

Can't we detect this based on some initial bytes? Hard to trust extensions for anything these days :D edit: something like [this](https://learn.microsoft.com/en-us/answers/questions/1299741/gzip-detection) > In the modified code, we are checking...