Martin Adámek

Results 768 comments of Martin Adámek

It works fine on my end, can you provide a complete repro? I wouldn't do it if I would consider it breaking, I am sure we can make this work...

> I can't provide a link to the repo where I have the issue I don't want your repository, I don't care about your app, I want a minimal example...

This should help d5d7f381363ab776b3c3af04a925a5547dbcdb65 I really don't understand what happened, it was working just fine and now I can reproduce in the same repo where it worked before.

> Moreover, as a side effect, this also allows defining a path on the class by the developer This is great, I've been thinking about introducing this for ages. We...

Yes, that is surely something to document. I don't think it makes sense to try to validate this, as having the entities in a single file is still a valid...

I guess this could go to https://mikro-orm.io/docs/metadata-providers. Also, do you think this should be a `perf` commit? Does it have a measurable difference? Maybe a `fix` would be better, or...

Btw does this help with the production build issue in bun mentioned in that discussion?

I'll merge this in as a fix, as I don't want to hold it for no reason, but I would still appreciate response to my previous comment as well as...

i can merge yours first and release to stable, since its a fix. i am keeping this one for v6.3, which i'd like to start working on soon (this weekend...

Hmm I would say this should be already working.