Martin Adámek
Martin Adámek
We can surely move the interface to the types package, but I'd like to first understand why, as this is the very first time we are hearing about such problems....
So crawlee is some optional dependency, or why would the user want to configure crawlee when they can't use it?
I realized I haven't commented on this anywhere, we only discussed this with Jindra on Thursday - so here is the thing: we already set this value to 1 on...
Yes, it's a hunch, based on years of experience working with ALS, seeing all the weird edge cases myself (been using it before it became stable). What I am sure...
Last time we were discussing this, someone (was it @jirimoravcik? maybe it was even in a different company 🙃) said it's actually a good thing to have the old number...
From what I read, it should note the start of the copyright notice, the license itself does not require a year at all. https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year And, on a different page, I...
@drobnikj I'd be up for merging this now, so we can test it better (and we'll hold the release till the docs are ready).
@stefansundin do you plan to finish this? I'd rather not merge such change without any added tests
Please add some tests for the new functionality. Also, note that what you did (making the `add` method async) is in fact breaking change, but I guess we can afford...
Sounds like a duplicate of #1771, maybe we should close that one?