crawlee icon indicating copy to clipboard operation
crawlee copied to clipboard

chore: Update the copyright notice

Open honzajavorek opened this issue 1 year ago • 4 comments

You may want to update this number unless the project is inactive. It's a small thing, but AFAIK (IANAL tho), the year marks a start of the period after which the work becomes public domain.

honzajavorek avatar Mar 26 '24 11:03 honzajavorek

Last time we were discussing this, someone (was it @jirimoravcik? maybe it was even in a different company 🙃) said it's actually a good thing to have the old number there, as it represents when the project started.

Personally, I never update this number, and I recall some frameworks used to do that and stopped as well, as it only adds clutter without any value.

So if we want to change this, I would be rather in favor of removing the number completely (or keeping the old value which represents the start). Checked a few larger projects and none of them had the year in their license file.

Thoughts @jancurn @mtrunkat?

B4nan avatar Mar 26 '24 12:03 B4nan

This is really a legal question cc @mnmkng

jancurn avatar Mar 26 '24 12:03 jancurn

as it represents when the project started

I've also seen things like Copyright 2018-2024 Apify Technologies s.r.o. And I'm sorry for summoning this bikeshedding demon upon you! I'm going through the tutorials and Crawlee claims to be open source, forever, so being a curious person, in light of recent re-licensing of Redis etc., I've checked what kind of license you're using. Then I spotted the number, recalled my good old Oracle times (spent way too much time with licenses) and couldn't restrain myself to this little update.

honzajavorek avatar Mar 26 '24 14:03 honzajavorek

From what I read, it should note the start of the copyright notice, the license itself does not require a year at all.

https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year

And, on a different page, I found that copyright is valid till the author dies (plus a few years), so this is not really important nowadays (but pretty much everybody starts those answers with "if I understood this right..." 🙃).

B4nan avatar Mar 26 '24 14:03 B4nan

so what about this one, merge or not? i would keep what we have, but no strong opinions really

B4nan avatar May 22 '24 08:05 B4nan

I don't think the change is needed.

mnmkng avatar May 23 '24 05:05 mnmkng

I'll close this. The current number doesn't cause any real issues for the project and doesn't bring any immediate risks. I feel bad that this PR takes attention and time of so many people.

honzajavorek avatar May 23 '24 07:05 honzajavorek