Martin Adámek

Results 768 comments of Martin Adámek

@barjin could look into this when he gets tired of fingerprint-suite issues :] not a huge priority, can happen one by one over time

> but that's an Apify issue we need to resolve that too, the tests are not passing, that is the goal FYI the failing test is the one you added,...

Looks like its failing even more than before with those changes (after the linked apify sdk PR got merged, but maybe the version wasnt published yet on NPM, and I...

@barjin keep in mind the main issue you should be looking into is the build failure, we can discuss code improvements once we can actually build it.

As I mentioned on slack, I do have commit rights here, but I do not have releasing under control, so if nothing changes soon, I will be forking this under...

Here is the initial version: https://github.com/mikro-orm/nestjs Not yet published, so for now you can inline the project manually. It does support v4, it also registers the EM flavours automatically, plus...

What about supporting that array param? Currently there is no other option as the entities array, right? I would support both (to maintain BC).

You can see example of migration to nest 7 here: https://github.com/mikro-orm/nestjs-realworld-example-app/commit/873833f47ed4ccee38a1a273697da73a8d37ca80 Basically nothing related to this package.

Personally I just call `orm.close()` in tests instead of `app.close()`. I was not aware of `app.close()` before my colleague used it in tests and was confused by the tests not...

So far there was no issue in this regard (never called close anywhere else, only in tests, and I am using the ORM from early days :]). Trying to find...