Martin Adámek

Results 768 comments of Martin Adámek

Some observations: - they use native private props, but TS is compiling it to lower level, so in fact its a TS helper called `__classPrivateFieldGet` (afaik the behaviour is the...

Right, looks like I found a way to get around it, your repro is passing with the changes from the linked PR. There are probably more things to handle this...

ooops, should have been a PR :] reposting the commit message here: > The link to `PuppeteerPool` won't work as the page is no longer part of 1.0 sdk docs,...

Fixed the links for `AutoscaledPool` only, as said above, the link for `PuppeteerPool` is not valid in v1, so that goes to 404. Not sure how we wanna handle that,...

The backstory is that if you use top level await on the Actor methods in a different file than the main.js where you call Actor.init, it will fail silently, because...

I dont follow what you mean. You simply cant call Actor.getInput in other than main.js file (where you call Actor.init). That is very error prone, especially now with top level...

And yes, that root input.json shortcut definitely needs to be supported with Actor.getInput, thats the main goal. But its a separate and unrelated issue.

> If you mean calling Actor.getInput() on top level in different file. Well - why would you even do it? =D Exactly that. Why would i put such call inside...

Not reexport, simply use it there. Why would I get the input from main.js and pass it to the routes somehow, when I can read it from the other file...

I did not needed to read it in main.js at all, thats the part you are probably missing.