actor-scraper icon indicating copy to clipboard operation
actor-scraper copied to clipboard

Fix broken links

Open mnmkng opened this issue 4 years ago • 4 comments

https://apify.com/apify/cheerio-scraper - link to https://sdk.apify.com/docs/api/autoscaledpool https://apify.com/apify/puppeteer-scraper - links to https://sdk.apify.com/docs/api/autoscaledpool and https://sdk.apify.com/docs/api/puppeteerpool

mnmkng avatar Jan 21 '21 15:01 mnmkng

ooops, should have been a PR :] reposting the commit message here:

The link to PuppeteerPool won't work as the page is no longer part of 1.0 sdk docs, found a note about it being deprecated and replaced with BrowserPool, but i'd rather let you handle that change as I don't fully understand all the differences.

B4nan avatar Mar 15 '21 15:03 B4nan

@B4nan Is this still relevant?

mnmkng avatar Apr 21 '21 11:04 mnmkng

Fixed the links for AutoscaledPool only, as said above, the link for PuppeteerPool is not valid in v1, so that goes to 404. Not sure how we wanna handle that, probably the mention about PuppeteerPool should be removed?

And apparently the docs (on web, not sdk docs) will need a rebuild, the AutoscaledPool is still not working - I fixed it only in this repo as I thought it is taken from here, but might be a duplicated content somewhere else.

Btw we might also make the old links just work (add redirects and keep the old url working too). I know how to do that in docusaurus v2, but there will be probably same/similar way to do so in v1 too.

e.g. this is how I am handling old URLs that were directy on the domain (/custom-driver), but now they are under /docs/custom-driver:

https://github.com/mikro-orm/mikro-orm/blob/master/docs/static/custom-driver/index.html

B4nan avatar Apr 21 '21 11:04 B4nan

Redirects are not easy to do in v1. Will have to do it once we migrate to v2. I would point the invalid puppeteer pool link to https://github.com/apify/browser-pool for now.

mnmkng avatar Apr 21 '21 13:04 mnmkng