aztec-verifier-contracts

aztec-verifier-contracts copied to clipboard

verify function visibility should be public to enable inheritance

2

Hello, I'm writing educational content about Noir in spanish and @critesjosh has been guiding me on the process. I stumbled into following issue while writing a guide on how to...

Turupawn

Changed verify visibility from external to public

2

Made this change only on `BaseStandardVerifier.sol` and `BaseUltraVerifier.sol` solidity files. The `IVerifier.sol` interfaces should continue `external` as is expected from interfaces.

Turupawn

compiling plonk_vk.sol throws YulException: too deep in the stack & then fails to verify proof format

13

Linked from issue in noir repo: https://github.com/noir-lang/noir/issues/1140 Here is the most updated issue: Update: I still got the "proof failed" error. Here I am doing it again to show you...

Jovonni

Compiling BaseUltraVerifier without optimizations results in StackTooDeep

4

When copying the verifier contracts into Remix IDE, it errors with StackTooDeep. This goes away when optimizations are enabled (they are disabled by default).

phated

Update BB to point to master.

LHerskind

Add the gas usage for the different version to the readme so it can easily be found without pulling repo and running tests.

LHerskind

docs(standard): Document how the r_0 calculation differs from the paper

2

# Overview Elaborate on the reasoning for why the implementation differs, issue created off the back of this recent comment from lasse. ``` // @note that our r_0 looks different...

Maddiaa0

# Overview Currently the ordering of the verification steps in the plonk paper are different to the implementation, elaborate on this at the top of the implementation

Maddiaa0

# Overview Current code documentation does not do much to reason about what the public input delta calculation is for and how to reason about it. Include documentation for this.

Maddiaa0

# Overview Generated from this comment: ``` @follow-up Elaborate on naming to easily match with the paper (part of step 9?) ```

Maddiaa0