aztec-verifier-contracts icon indicating copy to clipboard operation
aztec-verifier-contracts copied to clipboard

Changed verify visibility from external to public

Open Turupawn opened this issue 2 years ago • 2 comments

Made this change only on BaseStandardVerifier.sol and BaseUltraVerifier.sol solidity files. The IVerifier.sol interfaces should continue external as is expected from interfaces.

Turupawn avatar May 11 '23 04:05 Turupawn

As the verifier uses hardcoded memory accesses ( and does not continue from the free memory pointer ), we do not want to enable contracts to inherit from the Verifier contacts, but for them to make an external library calls to them. This avoids situations where the verifier overwrites memory within the parent contract.

I'll make a note on the linked issue about how is best to call them

Maddiaa0 avatar May 11 '23 16:05 Maddiaa0

Oh I see, makes sense. Thanks for note!

Turupawn avatar May 11 '23 23:05 Turupawn