Ayesh Karunaratne comments

Results 54 comments of


                                            Ayesh Karunaratne

[PHP 8.4][Intl] Add `grapheme_str_split`

Thank you @derrabus - I added polyfill and tests for `grapheme_str_split` to the Intl polyfill too.

[PHP 8.4][Intl] Add `grapheme_str_split`

Thank you @nicolas-grekas - really helpful comments, I addressed them and force-pushed. `\X` regex polyfill for PCRE1 is _very_ cool, it worked beautifully, 10,000 IQ regex 🤯 :)

[PHP 8.4][Intl] Add `grapheme_str_split`

One last push, thank you for being patient with this 💜

[PHP 8.4][Intl] Add `grapheme_str_split`

Perfect, fixed. So far, we exclude this ZW joiner case on PHP 7.2, and a known buggy PCRE2 \X capture on PCRE2 < 10.44 regardless of the PHP version.

Update `.gitattributes` to `export-ignore` paths

Thank you @theseer @kubawerlos

[PHP 8.4] Add `bcdivmod`

Thanks a lot for the reviews @stof @derrabus, really appreciate them, genuinely helpful ones. I will flesh out the polyfill and the tests soon.

[PHP 8.4] Add `bcdivmod`

Hi @alexandre-daubois - please feel free to take over, I got a bit too much in my plate for the coming weeks, unfortunately.

The Grapheme polyfill is failing tests when using `\X` as regex for clusters

Yeah, it's only fixed in PCRE 10.44 (I was the one who reported). This is worked around in the proposed `grapheme_str_split` [PR](https://github.com/symfony/polyfill/pull/483). I don't think there is a way to...

[PHP 8.5] Add `array_first` and `array_last`

@nicolas-grekas is it OK to bump the minimum PHP version to 7.3? If we have array_key_first/last, it would make this much more cleaner.

[PHP 8.5] Add `array_first` and `array_last`

Updated with `current(array_slice)`, and the other change suggestions from Nicolas. Thanks.