[PHP 8.5] Add `array_first` and `array_last`

[Ayesh]

trafficstars

Adds polyfills for the PHP 8.5's array_first and array_last functions.

The polyfills would have been a bit cleaner if we used the array_key_first and array_key_last functions, but they were added in PHP 7.3, and are not available on PHP 7.2.

This adds the same tests from php-src patch.

• RFC: array_first() and array_last()
• php-src commit
• PHP.Watch polyfill for PHP 8.0+

[mtarld]

I'm afraid that the current array_last implementation doesn't work with associative arrays. Indeed:

var_dump(array_slice(['a' => 2, 'b' => 1], -1, 1)[0]);

outputs a warning telling Undefined array key 0, whereas it should dump 1.

[nicolas-grekas]

I guess array_key_last should be used then

[Ayesh]

@nicolas-grekas is it OK to bump the minimum PHP version to 7.3? If we have array_key_first/last, it would make this much more cleaner.

[nicolas-grekas]

Ah right, then current(array_slice()) should do it

[Ayesh]

Updated with current(array_slice), and the other change suggestions from Nicolas. Thanks.

[stof]

is it OK to bump the minimum PHP version to 7.3? If we have array_key_first/last, it would make this much more cleaner.

We could depend on the polyfill-73 package

[nicolas-grekas]

Thank you @Ayesh.

[ruudk]

@nicolas-grekas I noticed this is not tagged yet. Could that be done 🙏 ?