Avni

Results 8 comments of Avni

@timosachsenberg @jpfeuffer would love to get your feedback on this, particularly the somewhat convoluted Nlohmann_json part. Let me know if I can clarify anything.

> I don't really understand if the json explicit conversion is working now or not? You have changes here that apparently pass on Linux. So what's working and what is...

> First batch of general comments: > > Arrow does not necessarily need to be in contrib. You could just install it from vcpkg or conda. But even if you...

> I get it now. The reason why you saw the errors on Linux is most likely that your CMake setting had no effect on the already built external json...

@jpfeuffer I have the option to export an arrow config file with ```-DARROW_JSON=ON``` - should I opt to use this instead and get rid of Nlohmann json through extern entirely?

The way we do it in contrib is particularly convoluted, I agree. Does that mean that we nix contrib altogether and fix the corresponding bugs re. cmakelists? Or does it...

My preliminary thoughts are that we could experiment with different versions of bcrypt in the appropriate .patch file, because it might just be a matter of specifying which version conda...

I'm curious about the functionality of the build system, can I ask where OpenMS is bundling bcrypt.dll? Is it with listing it in a certain cmake file?