Aviv Galmidi

Results 13 comments of Aviv Galmidi

Forgot to add Tzury as a reviewer, not sure if you feel comfortable approving confserver stuff Simon

@tzuryby Could you take a look at this PR and approve if possible?

I don't know the answer to this, the wording in the documentation is confusing and I know deny bot and allow bot act a bit differently inside the "left-to-right" system,...

Let's fix the conflicts (probably due to the terminology changes) and merge this in before we'll need to resolve conflicts again

That documentation is not updated to the new exclude / include lists and should now act similar to those lists in Flow Control https://docs.curiefense.io/settings/policies-rules/flow-control ``` Include Includes all requests in...

I'm not sure if this should be case sensitive or not Assuming we use a regex test for this part, wouldn't it just be adding `\i` flag in the end?

@yanivreblaze and @ItaiPrajgrod what do you think? Should the matching in Global Filters be case sensitive (= changing docs) or case insensitive (= changing code)?

Changing milestone 1.4.0 -> 1.4.1 which is set as the next release as 1.4.0 has been released last night

I'm not sure which one is correct between the current implementation and documentation @tzuryby or @yanivreblaze Do you remember why when setting a ban action in Curiefense, the ban timer...