Marcus Noble

Results 68 comments of Marcus Noble

It looks like this may not be possible with a Daemonset. Maybe It's worth looking in to creating a job that runs on all nodes?

The `IamInstanceProfile` property on AWSLaunchTemplates should be changed to `IAMInstanceProfile` (capital `IAM`) to be consistent with the same property on `AWSMachineSpec` and Go style guidelines on acronyms. See: https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/3586b3b25153ad525119199dfc9544b69ad0d15f/exp/api/v1beta2/types.go

From my (limited) understanding, this requires some qemu(-kvm) tooling to be installed onto the machine you're running this on. We managed to get around this at Giant Swarm by using...

Actually, looks like this is now added to the Docker image: https://github.com/kubernetes-sigs/image-builder/commit/6b2a0ecdf8a73e56c143a626b4630fb060e85473

/remove-lifecycle stale This would be a good QoL improvement.

/remove-lifecycle stale /help Yeah, we still want this. If anyone can help out with this in any way that would be fantastic!

@invidian I'm not sure what more `image-builder` can do here. The image-builder version is being published along with the AMI as an AWS tag but as you pointed out from...

Specifically I mean https://github.com/kubernetes-sigs/image-builder/blob/b7f8d4c3a2cad49497ee29d2b409c2e708b9c137/images/capi/packer/ami/packer.json#L153 I'm not sure how you currently build the AMIs but if you're already providing a `PACKER_VARS_FILE` you can update it to include a new `ami_description` property...

🤦 Sorry, I completely missed that while focussing on the tagging discussion. Yeah, I think it makes sense to include a `build-info` file or something similar that includes various details...