image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Follow-up concerning validate targets

Open jepio opened this issue 2 years ago • 10 comments

As @johananl pointed out here https://github.com/kubernetes-sigs/image-builder/pull/834#discussion_r876166796 , currently validate-* targets in the Makefile are out of sync with actual build targets. The makefile generates the validate-* targets from the build targets, but the separate entries are used when generating the make help output.

There are 2 points to tackle here:

  • [ ] sync validate targets with build targets (OR generate help string differently)?
  • [ ] automatically execute validate targets in CI

There is also the second comment https://github.com/kubernetes-sigs/image-builder/pull/834#discussion_r876165679:

  • [ ] harmonize the $BUILD_NAME == *flatcar* check to look the same across the codebase.

jepio avatar Jun 03 '22 12:06 jepio

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Sep 01 '22 13:09 k8s-triage-robot

/remove-lifecycle stale

johananl avatar Sep 01 '22 13:09 johananl

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 30 '22 13:11 k8s-triage-robot

/remove-lifecycle stale

johananl avatar Nov 30 '22 14:11 johananl

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Feb 28 '23 15:02 k8s-triage-robot

/remove-lifecycle stale

johananl avatar Mar 01 '23 09:03 johananl

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar May 30 '23 09:05 k8s-triage-robot

/remove-lifecycle stale

johananl avatar May 30 '23 10:05 johananl

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 21 '24 13:01 k8s-triage-robot

/remove-lifecycle stale

This would be a good QoL improvement.

AverageMarcus avatar Jan 22 '24 08:01 AverageMarcus