Antoine van der Lee

Results 99 comments of Antoine van der Lee

This should be fixed with #119.

Reopening this as it seems to not be fixed yet. @simonseyer you've mentioned in your PR before that this should have been fixed. Are you able to test this with...

This is probably related to some race conditions, which are visible using the Analyzer in Xcode. I'll fix these asap!

Looking at your crashlog now it seems that this is related to a key value observation retaining. Do you have the complete crashlog? I'm not sure if this is related...

@marmelroy I still feel like your the best to review this PR. Can you give an update on @jwelton 's changes?

Also, @andyj-at-aspin, it would be great to include your PR description example in a section to the readme!

> Do you need anything from me on this? I didn't notice that it was still open 😄 Nope, once CI finishes I'll merge it in!

This is pretty much how it should work, but it would obviously be much nicer if the SDK supports this out of the box. Feel free to open a PR...

> ~20 seconds on 10-core M1 Pro. I think that's as good as it gets for 75K lines. Interesting, I feel like it takes much longer locally for me. Either...

This should be fixed now!