Dillon Skaggs
Dillon Skaggs
>Is there a practical use case where this'd be needed? The reason to add another native is because as Linden pointed out, it might lead to unexpected behavior by people...
Going through and bumping a bunch of random prs is generally frowned upon. They'll get to it when they get to it
> Doesn't this has a potential to cause server's main-thread lags? Wouldn't this be the case with calling any blocking code inside of a ScRT? Also filtering functions taking 0.5ms...
It doesn't make much sense to up the node version when the next LTS releases in [two months](https://nodejs.dev/en/about/releases/)
Is webadmin even put into builds anymore? I thought it got no-oped a while ago.
Shouldn't the flag for the ConVar be `ConVar_UserPref`
You could probably handle all of this in OnGameFrame and not have to modify the natives to have a bunch of `g_richPresenceEnabled->GetValue()` calls everywhere ```cpp static std::shared_ptr g_richPresenceEnabled = std::make_shared("game_enableDiscordRichPresence",...
Servers have notoriously abused stuff like that
I don't understand why this is really necessary, this wouldn't match the same behavior on the client.
> At the moment we already do provide [some](https://github.com/citizenfx/fivem/blob/5e71f91d7bd846d8eb059c6a7a0db79f16e9d601/code/components/extra-natives-five/src/EntityDeletionNatives.cpp#L121) [feedback](https://github.com/citizenfx/fivem/blob/5e71f91d7bd846d8eb059c6a7a0db79f16e9d601/code/components/extra-natives-five/src/EntityDeletionNatives.cpp#L99-L107) about non-existent net-objects and game entities which is currently not reflected on server side. I think these types of warning...