Austin Gil

Results 100 comments of Austin Gil

I see. So you think it's better to remove SVG from that rule?

Yeah, I'd leave it on img for sure, but easy enough to remove from SVG. SVG is really just there for the other rules, but img for sure should have...

Yeah, I defo think this one does more harm than good in it's current state. Thanks for reporting

Yeah, I transitioned everything over to logical properties to make it more future proof, but I think in this case I actually want to use the height property since this...

Hey Rob, feel free to leave these sorts of issues open. It helps me keep track of what still needs to be addressed and I can always close it if...

Well it's been fixed now anyway ;)

Yeah, this is a tricky one because although it's mostly a reset, I also wanted to treat it somewhat like a classless library. Something I can use on any project...

I think the only time that would make a difference is if custom styles are imported before this library, but this is intended to be a reset, so it should...

Hey Rob, circling back on this. I like the feedback. Please continue to do so as you see fit. I'm definitely not right in all my decisions and it's good...

Yeah, this is a really good point. Any time I've used an SVG, the fill/stroke colors have always been on the paths themselves, never on the SVG tag. Most of...