Shivansh Subramanian

Results 40 comments of Shivansh Subramanian

Hey @DanielGoldfarb ! I was facing the same issue and would like to contribute if that is okay :) The approach seems simple enough, I am planning to accept a...

Hey @DanielGoldfarb, Update, its almost done! Approach: * Instead of working on [_construct_candlestick_collections](https://github.com/matplotlib/mplfinance/blob/master/src/mplfinance/_utils.py#L525-L529) as [you had suggested](https://github.com/matplotlib/mplfinance/issues/378#issuecomment-821918248), I thought it would be better to make [_updown_colors](https://github.com/matplotlib/mplfinance/blob/master/src/mplfinance/_utils.py#L179-L188) accept a new parameter...

Yup, made those changes. Will add more instructions as well

Hey @nilesh05apr , Maybe the steps are not clear enough, I will work on it to improve it. In the meanwhile: Firstly, create an issue for the estimator you want...

@fkiraly I have updated the wordings and migration instructions, hope they are better. I will add the code and examples for special cases in some time (since we have not...

Hey @nilesh05apr , Ensure that you have all the developer requirements installed, follow the [instructions mentioned here](https://www.sktime.org/en/stable/installation.html) Once that is done, to test the estimators (lets say you want to...

I see, I do not know if serialisation/deserialisation works for keras models (will check it out once). I was thinking something along the lines of (better explained in the step...

Hey @fkiraly , Can you please explain a doubt I had wrt this implementation? ```python if isinstance(serial, tuple): cls = serial[0] stored = serial[1] return cls.load_from_serial(stored) elif isinstance(serial, (str, ZipFile)):...

Hey @fkiraly , Wanted to confirm if the creation of `modules` directory here is in line with what you were recommending when we discussed this.

Sorry I forgot to comment on this, The issue I am facing with this classifier is that authors in sktime-dl have created there on keras layer (LSTMAttention) for this in...