AuroraLiu0823

Define a constant instead of duplicating this literal "total" 8 times.

5

Code Path:confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManagerMetrics.java Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences. On the other hand, constants can be referenced from many...

Replace the usage of the "instanceof" operator by a catch block.

1

Code Path:server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java Multiple catch blocks of the appropriate type should be used instead of catching a general exception, and then testing on the type.

Replace this "switch" statement by "if" statements to increase readability.

2

Code Path:server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ExpressionUtils.java switch statements are useful when there are many different cases depending on the value of the same expression. For just one or two cases however, the code will...