PythonRobotics icon indicating copy to clipboard operation
PythonRobotics copied to clipboard

Published 20 hours ago • verified publisher icon AtsushiSakai

Add probabilistic line extraction

Open tn3wman opened this issue 2 years ago • 5 comments

I see circle fitting and rectangle fitting. It would be helpful to include probabilistic line extraction to detect walls in indoor environments. There are several implementations written in MATLAB here: https://github.com/acschaefer/ple

tn3wman avatar Dec 06 '21 16:12 tn3wman

PR is welcome. But note that the OSS’s license is GPL3.0, so we convert the code to Python is not acceptable. The code should be based on the original paper.

AtsushiSakai avatar Dec 11 '21 05:12 AtsushiSakai

Paper link: https://github.com/acschaefer/ple/blob/master/doc/ple_iros2018.pdf

AtsushiSakai avatar Dec 11 '21 05:12 AtsushiSakai

Sounds good. I wasn't intending to convert the code from their research to Python, it's just the best example I have found with some implementations of more common algorithms such as iterative end point fit and split and merge. Hopefully it'll help troubleshoot issues with my own implementations, and if I get something working I'll create a PR.

tn3wman avatar Dec 16 '21 14:12 tn3wman

I'd be interested in developing a Python solution from the source paper. Can this be assigned to me?

jpcoffelt avatar Apr 25 '22 15:04 jpcoffelt

Hi. Thank you for your interest. @jpcoffelt Your PR is welcome. No need assignment.

AtsushiSakai avatar Apr 25 '22 22:04 AtsushiSakai