Yang, Bo

Do we really need the `lintMarkerAllowList` setting for `HHClientLinter` if there is such the `lintMarkerAllowList` global setting?

There is no "sublinter" concept in HHAST. A marker is for a lint error code, whose name could be either a class name without the -Linter suffix or an integer...

Given that the proposed setting is for markers, not linters, it would be straightforward to evaluate the allow list when parsing markers globally, instead of implementing the feature in each...

`arraykey` might be better. I typed it as `string` because it was `string` long before we introduced `HHClientLinter` and changing the type would break existing code.

I would create a new linter to raise lint errors for markers not in the allow list, and let all other linters simply ignore markers not in the allow list.

Close and reopen to trigger CI

Looks good to me

No ________________________________ From: Lexidor Digital ***@***.***> Sent: Friday, September 16, 2022 1:01:14 PM To: facebook/hhvm ***@***.***> Cc: Yang, Bo ***@***.***>; Mention ***@***.***> Subject: Re: [facebook/hhvm] hphp/util/trace.h:377:44: error: '... str() ...'...

When I tried to execute: ``` nix run github:nix-community/home-manager --no-write-lock-file ``` I got: ``` warning: not writing modified lock file of flake 'github:nix-community/home-manager': • Added input 'nixpkgs': 'github:NixOS/nixpkgs/b283b64580d1872333a99af2b4cef91bb84580cf' (2022-05-01) error:...

Would `nix develop` copy the entire source if the `devShell` has an `inputsFrom` attribute from a derivation whose `src` is `./.`? For example: - https://github.com/facebook/hhvm/blob/33269777563d24a0053b5b2bf81d96832e6cb868/flake.nix#L53-L55 - https://github.com/facebook/hhvm/blob/33269777563d24a0053b5b2bf81d96832e6cb868/hhvm.nix#L94