Atrue comments

Results 36 comments of


                                            Atrue

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

@steveluscher Yes, obviously there is a difference between the `||` and `??` operators, but from the user's perspective, there is no point in making this change, as code with the...

When an explicit `0` is passed as the close `code` it is honoured instead of defaulted back to `1000`

@steveluscher Alright, so you've catched the issue with '0' code. To ensure that this effort is not in vain, please include the test from the previous message and modify the...

Apparently, test.cb() has been deprecated by ava

Thanks, if you have time you can open a PR with the proper changes

ArrayBuffer instanceof - Check for ctor name

@hahacium It's possible an issue with jest https://github.com/jestjs/jest/issues/7780 Can you share a failing test snippet to check the issue?

fix: if server not found close code should be ABNORMAL

@easy-death please also add a test for this

Fix code example

@Borewit Sorry for the long delay. Can you please fix the same for the socket.io part of the README?