Atreyee Sinha

@registerrier @adonath I think this PR is ready for review now. The numerical integration implemented in the test is not nice, but that should be resolved in the next PR...

Thanks @adonath ! I addressed your comments, and opened #4072 for the `RegionNdMaps`. I am working on the template model now.

I have implemented `TemporalModel.integral()` in this PR itself. The integral is computed between the GTIs at the given energy. I think this makes the logic clearer. Can you do another...

@registerrier Indeed! I was not very happy about the same either. I have updated the PR to use a `PiecewiseNormSpectralModel` now. The test values did not change. The `PiecewiseNormSpectralModel` is...

I think we had expected this issue (of recipes breaking with updated gammapy versions) when setting up the recipes folder, and the decision was that: - Every recipe comes with...

I think @facero is preparing a new notebook using MCMC sampling with the present Gammapy version

I join a bit late into the conversation, sorry, but from @giacomodamico24 simulations, I think the results are rather consistent, no? If we talk about the 5-sigma threshold, then in...

Did you generate these datasets with gammapy @cosimoNigro ? Currently the `ReflectedRegionsBackgroundMaker` sets the mask on a dataset to `False` if no `counts_off` are found https://github.com/gammapy/gammapy/blob/09b9ee3307c0c2f8c62010b4185c2ea398b39c62/gammapy/makers/background/reflected.py#L585-L590 Would updating for checking...

Hi @HealthyPear ! If you have a background model, you can use the `make_map_background_irf` https://docs.gammapy.org/1.1/api/gammapy.makers.utils.make_map_background_irf.html?highlight=make_map_background_irf#gammapy.makers.utils.make_map_background_irf In this case, your `bkg` must be as per the GADF specifications of Background2D or...

In that case, maybe you can open a PR (a function in `gammapy.makers.utils`) and we can discuss there the exact usage. Thanks!