Atreyee Sinha

Results 138 comments of Atreyee Sinha

One problem with the `Examples` section is having the data in memory. Either we have to run everything in the code snippet, which defeats the point of a small example,...

Thanks for the discussion! So, if we are incompatible with some version of our dependencies, it should be mentioned in the `setup.cfg`, eg : astropy >=6.0; astropy

@Astro-Kirsty Sure, we can pass a wcs. But usually we always have a geom during the analysis, so this seems the simplest

As discussed in the dev call, this can be addressed with the `GeneralisedGaussianTemporalModel`. We need more documentation to expose this functionality

Suggestion from @adonath during the dev call: Have stateless classes as in eg: https://github.com/gammapy/gammapy/blob/main/gammapy/visualization/panel.py as this allows to plot multiple maps with same config by reusing a plotter object, instead...

Exclusion masks need not be regular shapes, so probably just size and location will not be sufficient

Thanks @LauraOlivera for the explanation. Yes, I understand the motivation behind those being optional, but I think that the MapDatasetMaker should still try to create those maps by default. We...

> It is up to the data producer to decide if this is available or not, for HAWC and SWGO it's not so far. But Gammapy can create one from...