Atreyee Sinha
Atreyee Sinha
I think we should not modify the `SensitivityEstimator` as it conforms to the default sensitivity definitions for CTA (eg: what pyirf does), but create a new `JointSensitivityEstimator` (probably inheriting from...
I have updated the author list for the 1.3 release @aaguasca @HealthyPear @GerritRo @VascoSch92 @samanthalwong Can you please add your full credentials as per the format: - given-names: family-names: affiliation:...
Thanks @Astro-Kirsty for undertaking this effort. Can you please update `slice` methods in the `maps` and `estimator` sub-packages, specially for multiple non-spatial axes. eg: https://github.com/gammapy/gammapy/blob/18b65d5cce21876d53aa7faf54aaeccd68e8b76c/gammapy/estimators/map/core.py#L1102 It can help to have...
I split this into two tutorials as discussed in the dev call. It might have been better to have this as two separate PRs, but I will be travelling for...
Ok, adapted! Now this has only the notebook for paramter ul
Thanks for all your comments. Indeed, it was incorrect of me to compute the ul from the pdf I have now updated the notebook, should be ready for review
Thanks a lot @QRemy for the restructuring. Looks much better! @Astro-Kirsty I have addressed your remaining comments. This should be good to merge now
Thanks @Astro-Kirsty ! I adapted the format.. @cgalelli! Yeah I agree. But the rebinning was there already.. Here I also added the slicing to show how to get a flat...
Superseded by #5637
Hi @tunbehaun273 ! When you say > the interpolation to a CAR geometry cutted the edge of the map. Do you mean that ``` geom1=WcsGeom.create(proj="CAR", binsz=1) geom1.coord_to_idx(dict(lon=0*u.deg, lat=90*u.deg)) ``` yields...