Etienne Laurin comments

Results 44 comments of


                                            Etienne Laurin

Bundle all the docs into a single page of a PDF manual

Please ignore the misleading issue name. Here is [a very early draft](http://atnnn.github.io/rethinkdb/RethinkDB_docs_dump.pdf) generated from the `pdf` branch of the `www` repo.

Bundle all the docs into a single page of a PDF manual

@afiskon it's a private repo at the moment.

Docs unclear about need to call cursor.close() after cursor.toArray()

A successful `toArray` does close the cursor. This should definitely be added to the docs.

Referencing known bugs in documentation

That seems like a good idea to me. Could you open this issue in https://github.com/rethinkdb/docs? A PR might be welcome too.

Add to .forEach documentation how to deal with a iteration that you don't wanna write

The documentation for forEach could benefit from being more detailed. See https://github.com/rethinkdb/rethinkdb/issues/3798#issuecomment-75135022 and https://github.com/rethinkdb/rethinkdb/issues/3798#issuecomment-75139364

Sample Command Duplication

The first paragraph of the [documentation](https://www.rethinkdb.com/api/javascript/sample/) already specifies that "selection is done without replacement".

latency

It is possible there is a bottleneck somewhere in this driver, I have done very little benchmarking. How are you measuring your numbers? How long does it take for the...

Typo in the py_str function

Does changing `maybe_unstr` to `maybe_str` fix the issue? I don't recognize that output format. Where is it from?

Tests fail to convert

It works for me, tested with Python 3.2.3 and 3.3.5. What version of Python 3 are you using? Here's the generated file [control.cc](https://gist.github.com/AtnNn/ed75553796999efac527).

Tests fail to convert

Thanks for investigating. It appears that Python 3.2 doesn't support the `u` prefix for strings, which causes some tests to be skipped. I've added support for Python 3.4's `ast.NameConstant` on...