Sam Atkins comments

Results 506 comments of


                                            Sam Atkins

LibWeb/HTML: Fill-in and update scrollParent and offsetParent

Changes: Dropped the hack as it's no longer necessary with #6719 merged.

TakeScreenshot: Add graphical frontend to `shot`

Don't have time right now to review this. Just wanted to say I agree that it would be nicer to not call the shell process, but I don't think that...

Crash with `random()` in `background-position`

> Hey! Can I work on this issue? Sure! We don't assign issues but you're welcome to work on it.

CSS `AccentColor` keyword should use the value of `accent-color`

> Hey. > > I wanted to make my first contribution, and it seems this issue is fitting for someone who has no experience with the project. Welcome! That's the...

CSS `AccentColor` keyword should use the value of `accent-color`

Cool. Take a look here: https://github.com/LadybirdBrowser/ladybird/blob/4b918cba50f0bac62c5c71dc32cbc7a551eb59b5/Libraries/LibWeb/Layout/Node.cpp#L414-L420 Before we do anything that might use `currentColor`, we have to make sure we compute the `color` property, so we do so early, on...

Fix svgcircle element node masking crash

Hi, this does fix the crash, but it's not correct. We should be able to get paths from elements inside a ``.

Fixed install.sh

Hi! You're going to need to be a bit more specific. What was broken, and how did you fix it?

What does it mean to map `-webkit-box-orient` to `flex-direction`?

Thanks. The telemetry thing is difficult because if sites use it as a backup alongside flex-direction (like in the good old "vendor prefix everything" days) then it'll show up as...

[css-typed-om]Define precisely which properties are list-valued and which aren't, probably in an appendix.

> Like the css-typed-om spec says, isn't `counter-reset` an example of a property that can be both? I.e. it's either a list of things, or a single value `none`. Sorry...

Seg Fault on Some Fedora 42 GNOME/KDE on Master Branch

I'm also on Fedora 42 KDE, and I *don't* get this issue, at least not when pulling master in an existing repo. So there's some extra nuance here.