Ashod Nakashian

Results 20 comments of Ashod Nakashian

I've been mulling over this for a week now (while looking at implementing a feature), not knowing this easy hack existed! (Note to self: check your missed notifications more frequently)....

Hi @ArshErgon! Thanks for your interest in this task. This is a file-server over http. When we get a request, we have to serve the file, but only after we...

> Hi, which tests should I exactly use for this issue? Thank you! @NoahbJohnson15, Ideally, all the tests should be run and pass. But for this change, manually loading documents...

Hi @R7JANV1. Yes, this is in progress. Stay tuned! And of course would highly appreciate help with testing, if possible.

@R7JANV1 Documents that have embedded video now play in Collabora Online. Inserting new audio/video in a document is a day-2 item, currently not supported (of course it can be done...

Thanks for reporting this @xklonx. Unfortunately, locks are still not fully supported by most implementations. There are outstanding tasks to improve locking, but this depends a lot on the support...

@codewithvk Thanks for your interest and for reaching out. This part of the code is implicated in a more complex feature to load documents asynchronously, which is quite a significant...

Thanks for the review and feedback! > So - overall this looks good. Seems we do the async CheckFileInfo, but don't pre-download the file (or did I miss that ?...

@internethering, thanks for your report. > **Describe the bug** If, for whatever reason, the document is not saved automatically when editing, the modified content is irrevocably lost after closing the...

I believe we need these two headers when serving the parent: ``` Cross-Origin-Opener-Policy: same-origin Cross-Origin-Embedder-Policy: require-corp ``` Also had to add script-src unsafe-eval to the CSP header of our frame/js/wasm...