Valery Arugin

Update mithril to latest version

1

subj

It is better to use atan2 here, otherwise incorrect values will be produced. (The same for other methods). https://github.com/qsantos/spyce/blob/2026837180df3fecebb3219df4756cf93b4de103/spyce/coordinates.py#L41 Also all moons in solar system missing NorthPole values.

This is a bug or leftover after refactoring? https://github.com/shadowmage45/KSPWheel/blob/75fc1ecec3ddbd13bc79263f4e80a502db790e2b/UnityProject/Assets/Scripts/KSPWheelCollider.cs#L1020

Please move calling of 'enter' method from initialize to set_state(). I need check some conditions and call tansition_to another state in 'enter' metod. When it's in initialze transition_to not working.

I was looking though code and found, that this function have no implementation, despite having a big comment section above it. Why is that? https://github.com/Scrawk/Brunetons-Improved-Atmospheric-Scattering/blob/b360e2cd1ebf32b0438ae7688aa30e9a06c6df09/Assets/BrunetonsImprovedAtmosphere/Shaders/ScatteringFunctions.cginc#L550

Compatibility for Netonsoft.Json 13?

2

Is it planned or this package is obosolete and abandoned? If not, maybe it is time to mark this repository as not maintained anymore?

Small aligment suggestion

1

https://github.com/stymee/SilkVulkanTutorial/blob/7d089b0f4f947bfcd152b657b8db9a27ca7fceba/Source/Chapter09PushConstants/FirstApp.cs#L30C17-L30C17 Here you can do something like this [StructLayout(LayoutKind.Explicit)] public struct SimplePushConstantData { [FieldOffset(0)] public Vector2 Offset; [FieldOffset(16)] public Vector3 Color; public static uint SizeOf() => (uint)Unsafe.SizeOf(); } Pack property...