Arthur Silva Sens

Results 148 comments of Arthur Silva Sens

Small decrease in memory allocations I can see a very small increase in CPU, not sure how much is relevant enough though I also see small increases in all query...

Initially, I thought the latency in different query steps would be insignificant, but when looking at overall query latency I can see a significant impact on the 0.99 quantile. ![image](https://github.com/prometheus/prometheus/assets/24193764/f00a196d-6fae-4ec9-bb6c-3809f0d27a2c)...

Hmmm, I didn't notice the compaction happening at the same time, but the compaction happens for both versions and only 1 spikes. The uneven query distribution sounds like a good...

Could you also make sure your PR description is correctly linked with the related issue? https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

> Thanks @ArthurSens for this latest commit. Eventually, I'm going to do this. By the way, I noticed there are some meetings in community channels, and I tried to join...

> I just had a quick look at the source code. it seems that comma is missing in the marshal functions, I'd like to work on the fix. Please do...

👋 Is this something we want to include in the 2.52 release? If yes, could you change the base branch to 'release-0.52'?

Yeah, I believe it does 😬. v2.52 is the only release branch with the buggy commit