Arthur Silva Sens

Results 418 comments of Arthur Silva Sens

Yes, I plan to continue the review! But if you find time to also give a review, please do :) Onboarding at the new job has been very time-consuming. Too...

> @ArthurSens is this still on your queue? Yes, it is! To be completely honest with you, @jyz0309, I've opened this PR to review quite a few times in the...

Since the next release is v3, couldn't we merge this into main right now?

> Per the discussion in the PR, I was asked not to Oh apologies, I should have read the discussion over there first 😬

Oh, looks like some commits weren't signed and there's one test failing 🤔 The test seems to be flaky, it's also failing in other PRs

@shivanthzen, looks like you accidentally added unrelated commits to your PR, could you keep only the ones that you've authored here?

> Can we update the proposed design in view of deciding to do histograms a different way? > > I see that `AppendCTZeroSample` was added in a different pattern. Can...

> @ArthurSens regarding Oleg's question, I think with remote write 2.0 we are expecting to use append hints more often in the remote write path right? If thats the case...

Can we close this one since #4533 has been merged?

I'm taking a look at this today, I took the liberty to write a benchmark for `execute`: ```go func BenchmarkExecute(b *testing.B) { for _, numSample := range []int{100, 1000, 10000}...