client_golang icon indicating copy to clipboard operation
client_golang copied to clipboard

[1617] Add ConstnativeHistogram

Open shivanthzen opened this issue 1 year ago • 2 comments

Fixes: #1617 Add exported ConstNativeHistogram - this can be used to build native histograms if one already has the relevant data without calling the observe function. A viable use case is while converting exponential histograms to nativehistograms.

shivanthzen avatar Oct 16 '24 12:10 shivanthzen

@ArthurSens Maybe you can take a look at this PR.

shivanthzen avatar Oct 16 '24 12:10 shivanthzen

Will have a look ASAP (which won't be before next week, sorry).

beorn7 avatar Oct 17 '24 16:10 beorn7

Thanks for the comments. I'll resolve them this weekend

shivanthzen avatar Oct 24 '24 19:10 shivanthzen

Oh, looks like some commits weren't signed and there's one test failing 🤔

The test seems to be flaky, it's also failing in other PRs

ArthurSens avatar Oct 30 '24 13:10 ArthurSens

I can sign the commits once the PR is approved, It seems signing will need a force push

shivanthzen avatar Nov 01 '24 13:11 shivanthzen

I can sign the commits once the PR is approved, It seems signing will need a force push

Yes, it changes the commits and therefore needs a force-push. However, it is essential to sign before approval. That's kind of the point.

beorn7 avatar Nov 02 '24 12:11 beorn7

Force pushed with signed commits.

shivanthzen avatar Nov 03 '24 19:11 shivanthzen

@shivanthzen, looks like you accidentally added unrelated commits to your PR, could you keep only the ones that you've authored here?

ArthurSens avatar Nov 04 '24 21:11 ArthurSens

@ArthurSens Removed other commits from the branch

shivanthzen avatar Nov 06 '24 07:11 shivanthzen

@beorn7 could you have another look at it?

kakkoyun avatar Nov 11 '24 14:11 kakkoyun

This is very close to the top of my review queue now. Will have a look soon, hopefully today.

beorn7 avatar Nov 12 '24 15:11 beorn7

Looks good to me, but there are lint warnings now. (They are coming from a recently added check, but they are still relevant.) Also, DCO signing is missing. @shivanthzen could you address the lint warnings and sign the commits? (Feel free to squash commits into fewer or just one before doing that.)

beorn7 avatar Nov 13 '24 10:11 beorn7

@beorn7 Done

shivanthzen avatar Nov 13 '24 16:11 shivanthzen

Follow-up here would be to tackle the addition of exemplars!

To clarify: This means making withExemplarsMetric.Write aware of native histogram exemplars. Then, we only need to update the doc comment of NewMetricWithExemplar and everything should work fine.

beorn7 avatar Nov 14 '24 14:11 beorn7