ArthurMinfotel

> Why not just completing/altering `$CFG_GLPI["default_impact_asset_types"]` ? I'm not sure a hook is necessary here It would be possible to change it in the plugin setup.php file by getting the...

> > > Why not just completing/altering `$CFG_GLPI["default_impact_asset_types"]` ? I'm not sure a hook is necessary here > > > > > > Hello Alexandre. This hook permets to define...

> Nevermind, OK for me. > > Can you add a test ? What kind of test would you like to be added ? Check the type of the image...

> @ArthurMinfotel > > Could you add some screenshots to your PR description? I've edited it to add several screenshoots, showing an example and the added functionnalities.

> We discussed about it with @orthagh and we think that the `is_private` flag should be removed from the database. Indeed, having both a public/private management + a entity/groups/users visibility...

@cedric-anne Could you tell me if what I've added for the creation of public search matches what you talked about ? Same for the migration. Thanks in advance.

Made some changes to take the deletion of savedsearch.form.php into account (what was causing issue when I last requested a review, didn't notice the deletion when I merged from main...

If everything is OK from a pratical point of view, I will start working on updating the current test functions and adding a new one for the targets.

Tests are updated. Things that are tested are : 1. Automatically adding the saved search's entity as target if input contains is_private with a falsy value. 2. For each type...

I've updated the controller to fix the issue with the class instance. For the lint, I believe those are not fixable :  The first and second are called in...